MediaWiki talk:Comments.js

Latest comment: 7 years ago by Nemo bis in topic Broken JavaScript

Bug: If article name contains colon, breaks link to opinion tab from talk page edit

Something wrong (I assume) with the code that strips out the namespace. For example the Opinion tab on Talk:Israel Journal: The Holy Land has an image problem goes to Comments:Israel Journal. I should be able to figure out and fix this sometime soonish. (Assuming nobody beats me to it). Bawolff 03:31, 19 December 2007 (UTC)Reply

[Resolved][Bug] checkCommentaryPageExist is not a function edit

Thanks for this code! :-) Really helped me on my own wiki, where we have an additional tab called "Journal".

I noticed the following error in the Firefox browser (using the "Firebug" extension) and Chrome (using the "Developer Tools"):

checkCommentaryPageExist is not a function
[Break On This Error] checkCommentaryPageExist(targetPage, 'ca-comments', OpinionParams);

When I changed your code:

var checkCommentaryPageExist = function (pageName, id, query) {

to:

function checkCommentaryPageExist(pageName, id, query) {

then problem was resolved ("No JavaScript Errors" message) and the above error does not occur. :-)

Best Regards, --Danny373 (talk) 14:48, 21 December 2011 (UTC)Reply

Hmm, that's odd. It definitely should work in both ways. Possibly something with load order, and the first one executing before the second is defined (but that'd be odd since the first is from an on document ready hook). Bawolff 23:46, 21 December 2011 (UTC)Reply
After moving the checkCommentaryPageExist function code to the top this small bug resolved and no more errors in the "Firebug" console. Thanks Bawolff! :) --Danny373 (talk) 07:22, 23 December 2011 (UTC)Reply

Would it be better to locate the "Collaboration" tab to the right of the "Opinions" tab, rather than to the left? edit

Personally, I think this would be better: more logical, more consistent. I am willing to make the necessary change in the code here, if I see sufficient agreement. But otherwise, I won't...since I doubt Wikipedia's "Be bold!" mantra extends to redesigning tabs on a non-Wikipedia project. Magic Sands (talk)

  • Not too sure about changing the order in that way. But, completely suppressing the tab on articles that haven't been published (we use flaggedrevs) would be most useful.
Ideally, it wouldn't be a tab, but appear at the bottom of the actual article as most sites would implement something like Disqus (sp?). --Brian McNeil / talk 22:58, 18 September 2012 (UTC)Reply

Broken JavaScript edit

MediaWiki developers found that this page probably breaks JavaScript for users (example: not seeing the buttons when editing a page). You probably need to edit this .js page and/or MediaWiki:Gadgets-definition as in the examples at phabricator:T122755. List more pages to check.

If you have questions or need help, please ask at phabricator:T164242. You can login with your wiki account. Best wishes, Nemo 09:49, 14 May 2017 (UTC)Reply

Return to "Comments.js" page.